1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify the preamble of QDateTimeEditPrivate::stepBy()

Browse Source 
Repetition and needless complexity: eleven lines rewritten in three.

Change-Id: I1dadbbc5329b18d3e25f38f73b69abd2d7aac30d
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
This commit is contained in:
Edward Welbourne 2020-09-24 15:00:21 +02:00
parent e0ff15ffd8
commit 03c12974bb
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/widgets/widgets/qdatetimeedit.cpp
View File

@ -2107,18 +2107,10 @@ QDateTime QDateTimeEditPrivate::stepBy(int sectionIndex, int steps, bool test) c
int pos = edit->cursorPosition(); int pos = edit->cursorPosition();
const SectionNode sn = sectionNode(sectionIndex); const SectionNode sn = sectionNode(sectionIndex);
int val;
// to make sure it behaves reasonably when typing something and then stepping in non-tracking mode // to make sure it behaves reasonably when typing something and then stepping in non-tracking mode
if (!test && pendingEmit) { if (!test && pendingEmit && q->validate(str, pos) == QValidator::Acceptable)
if (q->validate(str, pos) != QValidator::Acceptable) {
v = value.toDateTime();
} else {
v = q->dateTimeFromText(str); v = q->dateTimeFromText(str);
} int val = getDigit(v, sectionIndex);
val = getDigit(v, sectionIndex);
} else {
val = getDigit(v, sectionIndex);
}
val += steps; val += steps;