From 020f03c47e79b1d409d8edb509abdbf45cffe71d Mon Sep 17 00:00:00 2001 From: Mikolaj Boc Date: Thu, 8 Sep 2022 16:18:37 +0200 Subject: [PATCH] FileDialog: Use well-known DeleteOnClose instead of custom lambda The custom dialog-deleting lambda in QFileDialog::saveFileContent is redundant Change-Id: I03c2fa29ab0502b981460e34674a40a704a22e2d Reviewed-by: Giuseppe D'Angelo Reviewed-by: Volker Hilsheimer --- src/widgets/dialogs/qfiledialog.cpp | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/widgets/dialogs/qfiledialog.cpp b/src/widgets/dialogs/qfiledialog.cpp index c83c5e64d8c..ffec02d9381 100644 --- a/src/widgets/dialogs/qfiledialog.cpp +++ b/src/widgets/dialogs/qfiledialog.cpp @@ -2315,13 +2315,8 @@ void QFileDialog::getOpenFileContent(const QString &nameFilter, const std::funct fileOpenCompleted(fileName, fileContent); }; - auto dialogClosed = [=](int code) { - Q_UNUSED(code); - dialog->deleteLater(); - }; - connect(dialog, &QFileDialog::fileSelected, fileSelected); - connect(dialog, &QFileDialog::finished, dialogClosed); + dialog->setAttribute(Qt::WA_DeleteOnClose); dialog->show(); #endif } @@ -2360,13 +2355,8 @@ void QFileDialog::saveFileContent(const QByteArray &fileContent, const QString & } }; - auto dialogClosed = [=](int code) { - Q_UNUSED(code); - dialog->deleteLater(); - }; - connect(dialog, &QFileDialog::fileSelected, fileSelected); - connect(dialog, &QFileDialog::finished, dialogClosed); + dialog->setAttribute(Qt::WA_DeleteOnClose); dialog->show(); #endif }