From 016ee800bb3a6af79b31c267b5d5aad6a1398c3d Mon Sep 17 00:00:00 2001 From: Nicolas Fella Date: Sat, 2 Mar 2024 16:21:40 +0100 Subject: [PATCH] QKdeTheme: Fix default value for ItemViewActivateItemOnSingleClick Plasma 6 defaults to double click. When the default value is read we get an invalid QVariant. Use the proper default value in that case Pick-to: 6.7 6.5 Fixes: QTBUG-124481 Change-Id: I4cdbb04ee8f56b48bb6ab66ec6b3cd42bcf1b187 Reviewed-by: David Redondo Reviewed-by: Volker Hilsheimer (cherry picked from commit 92de89a941e48f5cd95cce40cd997022c3dc0ab9) Reviewed-by: Qt Cherry-pick Bot --- src/gui/platform/unix/qgenericunixthemes.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/gui/platform/unix/qgenericunixthemes.cpp b/src/gui/platform/unix/qgenericunixthemes.cpp index 90971ba94cd..8016e4dbab5 100644 --- a/src/gui/platform/unix/qgenericunixthemes.cpp +++ b/src/gui/platform/unix/qgenericunixthemes.cpp @@ -837,6 +837,10 @@ void QKdeThemePrivate::refresh() const QVariant singleClickValue = readKdeSetting(KdeSetting::SingleClick); if (singleClickValue.isValid()) singleClick = singleClickValue.toBool(); + else if (kdeVersion >= 6) // Plasma 6 defaults to double-click + singleClick = false; + else // earlier version to single-click + singleClick = true; const QVariant showIconsOnPushButtonsValue = readKdeSetting(KdeSetting::ShowIconsOnPushButtons); if (showIconsOnPushButtonsValue.isValid())