1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qnetworkcookie: reduce allocations

Browse Source 
by using QBAV::toInt instead of creating temp QBA + atoi

Change-Id: I90dd78e3fd989930071e3bd99c914087409aa948
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
Anton Kudryavtsev 2023-08-23 14:58:40 +03:00
parent ea25b3962b
commit 002c2723c9
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/network/access/qnetworkcookie.cpp
View File

@ -576,7 +576,7 @@ static inline bool isValueSeparator(char c)
static inline bool isWhitespace(char c) static inline bool isWhitespace(char c)
{ return c == ' ' || c == '\t'; } { return c == ' ' || c == '\t'; }
static bool checkStaticArray(int &val, const QByteArray &dateString, int at, const char *array, int size) static bool checkStaticArray(int &val, QByteArrayView dateString, int at, const char *array, int size)
{ {
if (dateString[at] < 'a' || dateString[at] > 'z') if (dateString[at] < 'a' || dateString[at] > 'z')
return false; return false;
@ -623,7 +623,7 @@ static bool checkStaticArray(int &val, const QByteArray &dateString, int at, con
Or in their own words: Or in their own words:
"} // else what the hell is this." "} // else what the hell is this."
*/ */
static QDateTime parseDateString(const QByteArray &dateString) static QDateTime parseDateString(QByteArrayView dateString)
{ {
QTime time; QTime time;
// placeholders for values when we are not sure it is a year, month or day // placeholders for values when we are not sure it is a year, month or day
@ -686,13 +686,13 @@ static QDateTime parseDateString(const QByteArray &dateString)
int hours = 0; int hours = 0;
switch (end - 1) { switch (end - 1) {
case 4: case 4:
minutes = atoi(dateString.mid(at + 3, 2).constData()); minutes = dateString.mid(at + 3, 2).toInt();
Q_FALLTHROUGH(); Q_FALLTHROUGH();
case 2: case 2:
hours = atoi(dateString.mid(at + 1, 2).constData()); hours = dateString.mid(at + 1, 2).toInt();
break; break;
case 1: case 1:
hours = atoi(dateString.mid(at + 1, 1).constData()); hours = dateString.mid(at + 1, 1).toInt();
break; break;
default: default:
at += end; at += end;
@ -743,7 +743,7 @@ static QDateTime parseDateString(const QByteArray &dateString)
if (isNumber(dateString[at + 1]) if (isNumber(dateString[at + 1])
&& isNumber(dateString[at + 2]) && isNumber(dateString[at + 2])
&& isNumber(dateString[at + 3])) { && isNumber(dateString[at + 3])) {
year = atoi(dateString.mid(at, 4).constData()); year = dateString.mid(at, 4).toInt();
at += 4; at += 4;
#ifdef PARSEDATESTRINGDEBUG #ifdef PARSEDATESTRINGDEBUG
qDebug() << "Year:" << year; qDebug() << "Year:" << year;
@ -759,7 +759,7 @@ static QDateTime parseDateString(const QByteArray &dateString)
if (dateString.size() > at + 1 if (dateString.size() > at + 1
&& isNumber(dateString[at + 1])) && isNumber(dateString[at + 1]))
++length; ++length;
int x = atoi(dateString.mid(at, length).constData()); int x = dateString.mid(at, length).toInt();
if (year == -1 && (x > 31 || x == 0)) { if (year == -1 && (x > 31 || x == 0)) {
year = x; year = x;
} else { } else {