From c4e15a032abef3567b999e33c1cc0eee3afecdf2 Mon Sep 17 00:00:00 2001 From: Zeex Date: Fri, 5 Jan 2018 19:48:43 +0600 Subject: [PATCH] Remove /J from MSVC compile flags https://msdn.microsoft.com/en-us/library/0d294k5z.aspx It looks like we don't need it. The 'char' type is signed on other platforms, so why should it be unsigned on Windows? Besides, its includion in add_definitions() prevented RC from compiling libpawn.rc with Visual Studio 2017's CMake tools. --- source/compiler/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/compiler/CMakeLists.txt b/source/compiler/CMakeLists.txt index b8db9b4..a4d48a2 100644 --- a/source/compiler/CMakeLists.txt +++ b/source/compiler/CMakeLists.txt @@ -45,7 +45,7 @@ if(HAVE_STRLCAT) endif() if(MSVC) - add_definitions(-D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE /J) + add_definitions(-D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE) if(MSVC LESS 1900) # MSVC 2013 and below don't support the "inline" keyword add_definitions(-Dinline=__inline)