1berry/obs-studio
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

obs-scripting: Fix script_path() python mem corruption

Browse Source 
Returning PyObject with borrowed reference will result in double free
and/or use after free issue.  Issue seen as crash when running Python
script calling script_path().
This commit is contained in:
Per Heed 2020-09-13 22:32:55 +02:00 committed by jp9000
parent 32bb14ddea
commit 318779be7a
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
deps/obs-scripting/obs-scripting-python.c vendored
View File

@ -147,8 +147,13 @@ void add_functions_to_py_module(PyObject *module, PyMethodDef *method_list)
static PyObject *py_get_current_script_path(PyObject *self, PyObject *args) static PyObject *py_get_current_script_path(PyObject *self, PyObject *args)
{ {
PyObject *dir;
UNUSED_PARAMETER(args); UNUSED_PARAMETER(args);
return PyDict_GetItemString(PyModule_GetDict(self), "__script_dir__");
dir = PyDict_GetItemString(PyModule_GetDict(self), "__script_dir__");
Py_XINCREF(dir);
return dir;
} }
static void get_defaults(struct obs_python_script *data, PyObject *get_defs) static void get_defaults(struct obs_python_script *data, PyObject *get_defs)