This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
53 lines
1.4 KiB
JavaScript
53 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
// Flags: --experimental-vm-modules
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { Module, createContext } = require('vm');
|
|
|
|
(async function test1() {
|
|
const context = createContext({
|
|
foo: 'bar',
|
|
baz: undefined,
|
|
typeofProcess: undefined,
|
|
});
|
|
const m = new Module(
|
|
'baz = foo; typeofProcess = typeof process; typeof Object;',
|
|
{ context }
|
|
);
|
|
assert.strictEqual(m.status, 'uninstantiated');
|
|
await m.link(common.mustNotCall());
|
|
m.instantiate();
|
|
assert.strictEqual(m.status, 'instantiated');
|
|
const result = await m.evaluate();
|
|
assert.strictEqual(m.status, 'evaluated');
|
|
assert.strictEqual(Object.getPrototypeOf(result), null);
|
|
assert.deepStrictEqual(context, {
|
|
foo: 'bar',
|
|
baz: 'bar',
|
|
typeofProcess: 'undefined'
|
|
});
|
|
assert.strictEqual(result.result, 'function');
|
|
}());
|
|
|
|
(async () => {
|
|
const m = new Module(
|
|
'global.vmResult = "foo"; Object.prototype.toString.call(process);'
|
|
);
|
|
await m.link(common.mustNotCall());
|
|
m.instantiate();
|
|
const { result } = await m.evaluate();
|
|
assert.strictEqual(global.vmResult, 'foo');
|
|
assert.strictEqual(result, '[object process]');
|
|
delete global.vmResult;
|
|
})();
|
|
|
|
(async () => {
|
|
const m = new Module('while (true) {}');
|
|
await m.link(common.mustNotCall());
|
|
m.instantiate();
|
|
await m.evaluate({ timeout: 500 })
|
|
.then(() => assert(false), () => {});
|
|
})();
|