d9e95d8982
This commit validates the file descriptor passed to the TTY wrap's guessHandleType() function. Prior to this commit, a bad file descriptor would trigger an abort in the binding layer. PR-URL: https://github.com/nodejs/node/pull/21429 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
52 lines
1.3 KiB
JavaScript
52 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
common.expectsError(() => {
|
|
new net.Socket({ fd: -1 });
|
|
}, { code: 'ERR_OUT_OF_RANGE' });
|
|
|
|
common.expectsError(() => {
|
|
new net.Socket({ fd: 'foo' });
|
|
}, { code: 'ERR_INVALID_ARG_TYPE' });
|
|
|
|
function test(sock, readable, writable) {
|
|
let socket;
|
|
if (sock instanceof net.Socket) {
|
|
socket = sock;
|
|
} else {
|
|
socket = new net.Socket(sock);
|
|
socket.unref();
|
|
}
|
|
|
|
assert.strictEqual(socket.readable, readable);
|
|
assert.strictEqual(socket.writable, writable);
|
|
}
|
|
|
|
test(undefined, false, false);
|
|
|
|
const server = net.createServer(common.mustCall((socket) => {
|
|
test(socket, true, true);
|
|
test({ handle: socket._handle }, false, false);
|
|
test({ handle: socket._handle, readable: true, writable: true }, true, true);
|
|
if (socket._handle.fd >= 0) {
|
|
test(socket._handle.fd, false, false);
|
|
test({ fd: socket._handle.fd }, false, false);
|
|
test({ fd: socket._handle.fd, readable: true, writable: true }, true, true);
|
|
}
|
|
|
|
server.close();
|
|
}));
|
|
|
|
server.listen(common.mustCall(() => {
|
|
const { port } = server.address();
|
|
const socket = net.connect(port, common.mustCall(() => {
|
|
test(socket, true, true);
|
|
socket.end();
|
|
}));
|
|
|
|
test(socket, false, true);
|
|
}));
|