bc23681aa2
Expand argument validation through compat API, adjust behaviour of response.end to not throw if stream already closed to match http1, adjust behaviour of writeContinue to not throw if stream already closed and other very small tweaks. Add tests for added and fixed behaviour. Add tests for edge case behaviours of setTimeout, createPushResponse, destroy, end and trailers. PR-URL: https://github.com/nodejs/node/pull/15473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
61 lines
1.8 KiB
JavaScript
61 lines
1.8 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const net = require('net');
|
|
|
|
// Http2ServerRequest should expose convenience properties
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall(function(request, response) {
|
|
const expected = {
|
|
version: '2.0',
|
|
httpVersionMajor: 2,
|
|
httpVersionMinor: 0
|
|
};
|
|
|
|
assert.strictEqual(request.closed, false);
|
|
assert.strictEqual(request.code, h2.constants.NGHTTP2_NO_ERROR);
|
|
|
|
assert.strictEqual(request.httpVersion, expected.version);
|
|
assert.strictEqual(request.httpVersionMajor, expected.httpVersionMajor);
|
|
assert.strictEqual(request.httpVersionMinor, expected.httpVersionMinor);
|
|
|
|
assert.ok(request.socket instanceof net.Socket);
|
|
assert.ok(request.connection instanceof net.Socket);
|
|
assert.strictEqual(request.socket, request.connection);
|
|
|
|
response.on('finish', common.mustCall(function() {
|
|
assert.strictEqual(request.closed, true);
|
|
assert.strictEqual(request.code, h2.constants.NGHTTP2_NO_ERROR);
|
|
process.nextTick(() => {
|
|
assert.strictEqual(request.socket, undefined);
|
|
server.close();
|
|
});
|
|
}));
|
|
response.end();
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('end', common.mustCall(function() {
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
request.resume();
|
|
}));
|
|
}));
|