907941d48e
Validate the timeout option in the ClientRequest() constructor to prevent asynchronously thrown validation errors. PR-URL: https://github.com/nodejs/node/pull/26214 Fixes: https://github.com/nodejs/node/issues/26143 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
38 lines
923 B
JavaScript
38 lines
923 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
assert.throws(() => {
|
|
http.request({ timeout: null });
|
|
}, /The "timeout" argument must be of type number/);
|
|
|
|
const options = {
|
|
method: 'GET',
|
|
port: undefined,
|
|
host: '127.0.0.1',
|
|
path: '/',
|
|
timeout: 1
|
|
};
|
|
|
|
const server = http.createServer();
|
|
|
|
server.listen(0, options.host, function() {
|
|
options.port = this.address().port;
|
|
const req = http.request(options);
|
|
req.on('error', function() {
|
|
// this space is intentionally left blank
|
|
});
|
|
req.on('close', common.mustCall(() => server.close()));
|
|
|
|
let timeout_events = 0;
|
|
req.on('timeout', common.mustCall(() => timeout_events += 1));
|
|
setTimeout(function() {
|
|
req.destroy();
|
|
assert.strictEqual(timeout_events, 1);
|
|
}, common.platformTimeout(100));
|
|
setTimeout(function() {
|
|
req.end();
|
|
}, common.platformTimeout(10));
|
|
});
|