85a4e25775
Add type checking for options.hostname / options.host Maintains the use of `undefined` and `null` for default `localhost`, but other falsy values (like `false`, `0` and `NaN`) are rejected. PR-URL: https://github.com/nodejs/node/pull/12494 Ref: https://github.com/nodejs/node/issues/12488 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
28 lines
913 B
JavaScript
28 lines
913 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
// All of these values should cause http.request() to throw synchronously
|
|
// when passed as the value of either options.hostname or options.host
|
|
const vals = [{}, [], NaN, Infinity, -Infinity, true, false, 1, 0, new Date()];
|
|
|
|
function errCheck(name) {
|
|
return new RegExp(`^TypeError: "options\\.${name}" must either be a ` +
|
|
'string, undefined or null$');
|
|
}
|
|
|
|
vals.forEach((v) => {
|
|
assert.throws(() => http.request({hostname: v}), errCheck('hostname'));
|
|
assert.throws(() => http.request({host: v}), errCheck('host'));
|
|
});
|
|
|
|
// These values are OK and should not throw synchronously
|
|
['', undefined, null].forEach((v) => {
|
|
assert.doesNotThrow(() => {
|
|
http.request({hostname: v}).on('error', common.noop);
|
|
http.request({host: v}).on('error', common.noop);
|
|
});
|
|
});
|