7d86a5324b
Lazy load _http_common and HTTPParser so that the 'http_parser' binding can be monkey patched before any internal modules require it. This also probably improves startup performance minimally for programs that never require the HTTP stack. Fixes: https://github.com/nodejs/node/issues/23716 Fixes: https://github.com/creationix/http-parser-js/issues/57 PR-URL: https://github.com/nodejs/node/pull/24006 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
// Flags: --expose-internals
|
|
|
|
'use strict';
|
|
|
|
const { internalBinding } = require('internal/test/binding');
|
|
|
|
// Monkey patch before requiring anything
|
|
class DummyParser {
|
|
constructor(type) {
|
|
this.test_type = type;
|
|
}
|
|
}
|
|
DummyParser.REQUEST = Symbol();
|
|
internalBinding('http_parser').HTTPParser = DummyParser;
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { spawn } = require('child_process');
|
|
const { parsers } = require('_http_common');
|
|
|
|
// Test _http_common was not loaded before monkey patching
|
|
const parser = parsers.alloc();
|
|
assert.strictEqual(parser instanceof DummyParser, true);
|
|
assert.strictEqual(parser.test_type, DummyParser.REQUEST);
|
|
|
|
if (process.argv[2] !== 'child') {
|
|
// Also test in a child process with IPC (specific case of https://github.com/nodejs/node/issues/23716)
|
|
const child = spawn(process.execPath, [
|
|
'--expose-internals', __filename, 'child'
|
|
], {
|
|
stdio: ['inherit', 'inherit', 'inherit', 'ipc']
|
|
});
|
|
child.on('exit', common.mustCall((code, signal) => {
|
|
assert.strictEqual(code, 0);
|
|
assert.strictEqual(signal, null);
|
|
}));
|
|
}
|