676e61872f
The assert.fail function signature has the message as the third argument
but, understandably, it is often assumed that it is the first argument
(or at least the first argument if no other arguments are passed).
This corrects the assert.fail() invocations in the Node.js tests.
Before:
assert.fail('message');
// result: AssertionError: 'message' undefined undefined
After:
assert.fail(null, null, 'message');
// result: AssertionError: message
PR-URL: https://github.com/nodejs/node/pull/3378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
49 lines
1.2 KiB
JavaScript
49 lines
1.2 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var fs = require('fs');
|
|
|
|
if (!common.hasCrypto) {
|
|
console.log('1..0 # Skipped: missing crypto');
|
|
return;
|
|
}
|
|
var https = require('https');
|
|
|
|
var options = {
|
|
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
|
|
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
|
|
};
|
|
|
|
var invalidLocalAddress = '1.2.3.4';
|
|
var gotError = false;
|
|
|
|
var server = https.createServer(options, function(req, res) {
|
|
console.log('Connect from: ' + req.connection.remoteAddress);
|
|
|
|
req.on('end', function() {
|
|
res.writeHead(200, { 'Content-Type': 'text/plain' });
|
|
res.end('You are from: ' + req.connection.remoteAddress);
|
|
});
|
|
req.resume();
|
|
});
|
|
|
|
server.listen(common.PORT, '127.0.0.1', function() {
|
|
var req = https.request({
|
|
host: 'localhost',
|
|
port: common.PORT,
|
|
path: '/',
|
|
method: 'GET',
|
|
localAddress: invalidLocalAddress
|
|
}, function(res) {
|
|
assert.fail(null, null, 'unexpectedly got response from server');
|
|
}).on('error', function(e) {
|
|
console.log('client got error: ' + e.message);
|
|
gotError = true;
|
|
server.close();
|
|
}).end();
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.ok(gotError);
|
|
});
|