nodejs/test/parallel/test-http2-multi-content-length.js
Brian White 8f6ab9f799
Revert "stream: prevent 'end' to be emitted after 'error'"
This reverts commit 08577906569a4c2de70ad2a861e2f8456cd8fcdd.

PR-URL: https://github.com/nodejs/node/pull/20449
Fixes: https://github.com/nodejs/node/issues/20334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2018-05-07 09:44:26 +02:00

65 lines
1.7 KiB
JavaScript

'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const Countdown = require('../common/countdown');
const server = http2.createServer();
server.on('stream', common.mustCall((stream) => {
stream.respond();
stream.end();
}));
server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
const countdown = new Countdown(2, () => {
server.close();
client.close();
});
// Request 1 will fail because there are two content-length header values
common.expectsError(
() => {
client.request({
':method': 'POST',
'content-length': 1,
'Content-Length': 2
});
}, {
code: 'ERR_HTTP2_HEADER_SINGLE_VALUE',
type: TypeError,
message: 'Header field "content-length" must only have a single value'
}
);
{
// Request 2 will succeed
const req = client.request({
':method': 'POST',
'content-length': 1
});
req.resume();
req.on('end', common.mustCall());
req.on('close', common.mustCall(() => countdown.dec()));
req.end('a');
}
{
// Request 3 will fail because nghttp2 does not allow the content-length
// header to be set for non-payload bearing requests...
const req = client.request({ 'content-length': 1 });
req.resume();
req.on('end', common.mustCall());
req.on('close', common.mustCall(() => countdown.dec()));
req.on('error', common.expectsError({
code: 'ERR_HTTP2_STREAM_ERROR',
type: Error,
message: 'Stream closed with error code NGHTTP2_PROTOCOL_ERROR'
}));
}
}));