8ebd339031
Allow loading add-ons from multiple Node.js instances if they are declared context-aware; in particular, this applies to N-API addons. Also, plug a memory leak that occurred when registering N-API addons. Refs: https://github.com/nodejs/node/pull/23319 PR-URL: https://github.com/nodejs/node/pull/26175 Fixes: https://github.com/nodejs/node/issues/21481 Fixes: https://github.com/nodejs/node/issues/21783 Fixes: https://github.com/nodejs/node/issues/25662 Fixes: https://github.com/nodejs/node/issues/20239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
59 lines
1.5 KiB
C++
59 lines
1.5 KiB
C++
#include <assert.h>
|
|
#include <node.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <v8.h>
|
|
#include <uv.h>
|
|
|
|
using v8::Context;
|
|
using v8::HandleScope;
|
|
using v8::Isolate;
|
|
using v8::Local;
|
|
using v8::Object;
|
|
using v8::Value;
|
|
|
|
size_t count = 0;
|
|
|
|
struct statically_allocated {
|
|
statically_allocated() {
|
|
assert(count == 0);
|
|
printf("ctor ");
|
|
}
|
|
~statically_allocated() {
|
|
assert(count == 0);
|
|
printf("dtor ");
|
|
}
|
|
} var;
|
|
|
|
void Dummy(void*) {
|
|
assert(0);
|
|
}
|
|
|
|
void Cleanup(void* str) {
|
|
printf("%s ", static_cast<const char*>(str));
|
|
}
|
|
|
|
void Initialize(Local<Object> exports,
|
|
Local<Value> module,
|
|
Local<Context> context) {
|
|
node::AddEnvironmentCleanupHook(
|
|
context->GetIsolate(),
|
|
Cleanup,
|
|
const_cast<void*>(static_cast<const void*>("cleanup")));
|
|
node::AddEnvironmentCleanupHook(context->GetIsolate(), Dummy, nullptr);
|
|
node::RemoveEnvironmentCleanupHook(context->GetIsolate(), Dummy, nullptr);
|
|
|
|
if (getenv("addExtraItemToEventLoop") != nullptr) {
|
|
// Add an item to the event loop that we do not clean up in order to make
|
|
// sure that for the main thread, this addon's memory persists even after
|
|
// the Environment instance has been destroyed.
|
|
static uv_async_t extra_async;
|
|
uv_loop_t* loop = node::GetCurrentEventLoop(context->GetIsolate());
|
|
int err = uv_async_init(loop, &extra_async, [](uv_async_t*) {});
|
|
assert(err == 0);
|
|
uv_unref(reinterpret_cast<uv_handle_t*>(&extra_async));
|
|
}
|
|
}
|
|
|
|
NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
|