Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
57 lines
1.4 KiB
JavaScript
57 lines
1.4 KiB
JavaScript
'use strict';
|
|
// Verify that the 'upgrade' header causes an 'upgrade' event to be emitted to
|
|
// the HTTP client. This test uses a raw TCP server to better control server
|
|
// behavior.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var http = require('http');
|
|
var net = require('net');
|
|
|
|
// Create a TCP server
|
|
var srv = net.createServer(function(c) {
|
|
c.on('data', function(d) {
|
|
c.write('HTTP/1.1 101\r\n');
|
|
c.write('hello: world\r\n');
|
|
c.write('connection: upgrade\r\n');
|
|
c.write('upgrade: websocket\r\n');
|
|
c.write('\r\n');
|
|
c.write('nurtzo');
|
|
});
|
|
|
|
c.on('end', function() {
|
|
c.end();
|
|
});
|
|
});
|
|
|
|
srv.listen(0, '127.0.0.1', common.mustCall(function() {
|
|
|
|
var req = http.get({
|
|
port: this.address().port,
|
|
headers: {
|
|
connection: 'upgrade',
|
|
upgrade: 'websocket'
|
|
}
|
|
});
|
|
req.on('upgrade', common.mustCall(function(res, socket, upgradeHead) {
|
|
var recvData = upgradeHead;
|
|
socket.on('data', function(d) {
|
|
recvData += d;
|
|
});
|
|
|
|
socket.on('close', common.mustCall(function() {
|
|
assert.equal(recvData, 'nurtzo');
|
|
}));
|
|
|
|
console.log(res.headers);
|
|
var expectedHeaders = {'hello': 'world',
|
|
'connection': 'upgrade',
|
|
'upgrade': 'websocket' };
|
|
assert.deepStrictEqual(expectedHeaders, res.headers);
|
|
|
|
socket.end();
|
|
srv.close();
|
|
}));
|
|
}));
|