1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
20,479 Commits 59 Branches 887 Tags
Commit Graph

3 Commits

Author SHA1 Message Date
Joyee Cheung
9f122e3b55
fs: throw fs.close errors in JS 
* Collect the error context in both JS and C++, then throw
  the error in JS
* Test that the errors thrown from fs.close and fs.closeSync
  includes the correct error code, error number and syscall
  properties

PR-URL: https://github.com/nodejs/node/pull/17338
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2017-12-28 03:08:25 +08:00
James M Snell
6100e12667 fs: move type checking to js 
PR-URL: https://github.com/nodejs/node/pull/17667
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2017-12-22 12:49:10 -08:00
James M Snell
8974df15a9 fs: move type checking for fs.close to js 
PR-URL: https://github.com/nodejs/node/pull/17334
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2017-12-13 13:26:21 -08:00