1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
28,253 Commits 59 Branches 887 Tags
Commit Graph

2 Commits

Author SHA1 Message Date
Gus Caplan
5e7946fe79 vm: refactor SourceTextModule 
- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic

Closes: https://github.com/nodejs/node/issues/29030

Co-Authored-By: Michaël Zasso <targos@protonmail.com>

PR-URL: https://github.com/nodejs/node/pull/29776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
 2019-10-02 15:54:35 -07:00
kball
99879cac86 vm: increase code coverage of source_text_module.js 
PR-URL: https://github.com/nodejs/node/pull/28350
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2019-07-29 22:47:36 -07:00