nodejs

1berry/nodejs

Fork 0

Commit Graph

Author	SHA1	Message	Date
cjihrig	79e41cc7b0	dgram: hide underscored Socket properties dgram sockets have a fair number of exposed private properties. This commit hides them all behind a single symbol property. PR-URL: https://github.com/nodejs/node/pull/21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	2018-07-28 00:35:08 -04:00
cjihrig	1683299c33	test: add coverage to dgram receive error case This commit adds coverage for the case where a dgram socket handle receives a message, but nread < 0, indicating an error. PR-URL: https://github.com/nodejs/node/pull/11241 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>	2017-02-10 12:17:19 -05:00

Author

SHA1

Message

Date

cjihrig

79e41cc7b0

dgram: hide underscored Socket properties

dgram sockets have a fair number of exposed private properties.
This commit hides them all behind a single symbol property.

PR-URL: https://github.com/nodejs/node/pull/21923
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

2018-07-28 00:35:08 -04:00

cjihrig

1683299c33

test: add coverage to dgram receive error case

This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: https://github.com/nodejs/node/pull/11241
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

2017-02-10 12:17:19 -05:00

2 Commits