1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-vm-new-script-new-context

Browse Source 
* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements

PR-URL: https://github.com/nodejs/node/pull/14536
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-07-29 09:04:00 -07:00
parent 8c2cac650a
commit ff1a51920e
1 changed files with 71 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

117
test/parallel/test-vm-new-script-new-context.js
View File

@ -20,71 +20,88 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict'; 'use strict';
const common = require('../common'); require('../common');
const assert = require('assert'); const assert = require('assert');
const Script = require('vm').Script; const Script = require('vm').Script;
common.globalCheck = false; {
const script = new Script('\'passed\';');
const result1 = script.runInNewContext();
const result2 = script.runInNewContext();
assert.strictEqual('passed', result1);
assert.strictEqual('passed', result2);
}
console.error('run a string'); {
let script = new Script('\'passed\';'); const script = new Script('throw new Error(\'test\');');
console.error('script created'); assert.throws(function() {
const result1 = script.runInNewContext();
const result2 = script.runInNewContext();
assert.strictEqual('passed', result1);
assert.strictEqual('passed', result2);
console.error('thrown error');
script = new Script('throw new Error(\'test\');');
assert.throws(function() {
script.runInNewContext(); script.runInNewContext();
}, /^Error: test$/); }, /^Error: test$/);
}
{
console.error('undefined reference'); const script = new Script('foo.bar = 5;');
script = new Script('foo.bar = 5;'); assert.throws(function() {
assert.throws(function() {
script.runInNewContext(); script.runInNewContext();
}, /^ReferenceError: foo is not defined$/); }, /^ReferenceError: foo is not defined$/);
}
{
global.hello = 5;
const script = new Script('hello = 2');
script.runInNewContext();
assert.strictEqual(5, global.hello);
global.hello = 5; // cleanup
script = new Script('hello = 2'); delete global.hello;
script.runInNewContext(); }
assert.strictEqual(5, global.hello);
{
console.error('pass values in and out'); global.code = 'foo = 1;' +
global.code = 'foo = 1;' +
'bar = 2;' + 'bar = 2;' +
'if (baz !== 3) throw new Error(\'test fail\');'; 'if (baz !== 3) throw new Error(\'test fail\');';
global.foo = 2; global.foo = 2;
global.obj = { foo: 0, baz: 3 }; global.obj = { foo: 0, baz: 3 };
script = new Script(global.code); const script = new Script(global.code);
/* eslint-disable no-unused-vars */ /* eslint-disable no-unused-vars */
const baz = script.runInNewContext(global.obj); const baz = script.runInNewContext(global.obj);
/* eslint-enable no-unused-vars */ /* eslint-enable no-unused-vars */
assert.strictEqual(1, global.obj.foo); assert.strictEqual(1, global.obj.foo);
assert.strictEqual(2, global.obj.bar); assert.strictEqual(2, global.obj.bar);
assert.strictEqual(2, global.foo); assert.strictEqual(2, global.foo);
console.error('call a function by reference'); //cleanup
script = new Script('f()'); delete global.code;
function changeFoo() { global.foo = 100; } delete global.foo;
script.runInNewContext({ f: changeFoo }); delete global.obj;
assert.strictEqual(global.foo, 100); }
console.error('modify an object by reference'); {
script = new Script('f.a = 2'); const script = new Script('f()');
const f = { a: 1 }; function changeFoo() { global.foo = 100; }
script.runInNewContext({ f: f }); script.runInNewContext({ f: changeFoo });
assert.strictEqual(f.a, 2); assert.strictEqual(global.foo, 100);
assert.throws(function() { // cleanup
delete global.foo;
}
{
const script = new Script('f.a = 2');
const f = { a: 1 };
script.runInNewContext({ f: f });
assert.strictEqual(f.a, 2);
assert.throws(function() {
script.runInNewContext(); script.runInNewContext();
}, /^ReferenceError: f is not defined$/); }, /^ReferenceError: f is not defined$/);
}
console.error('invalid this'); {
assert.throws(function() { const script = new Script('');
assert.throws(function() {
script.runInNewContext.call('\'hello\';'); script.runInNewContext.call('\'hello\';');
}, /^TypeError: this\.runInContext is not a function$/); }, /^TypeError: this\.runInContext is not a function$/);
}