1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove the third string literal argument from assert.strictEqual()

Browse Source 
Third string literal argument in assert.strictEqual() needs to be
removed. Otherwise, on AssertionError it would not display the
values that failed the check -- this hinders debugging.
The string literals are added as comments above the check.

PR-URL: https://github.com/nodejs/node/pull/21406
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Kevin Thomas 2018-06-19 20:09:03 +05:30 committed by Rich Trott
parent e43d91cdc1
commit fea3595c2f
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-string-decoder-end.js
View File

@ -103,8 +103,10 @@ function testBuf(encoding, buf) {
// .toString() on the buffer
const res3 = buf.toString(encoding);
assert.strictEqual(res1, res3, 'one byte at a time should match toString');
assert.strictEqual(res2, res3, 'all bytes at once should match toString');
// One byte at a time should match toString
assert.strictEqual(res1, res3);
// All bytes at once should match toString
assert.strictEqual(res2, res3);
}
function testEnd(encoding, incomplete, next, expected) {