1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: remove tentativeness in pull-requests.md

Browse Source 
There are some uses of "in general" that are unnecessary. (We don't need
to be tentative about the fact that tests should pass, for example.)

PR-URL: https://github.com/nodejs/node/pull/19123
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2018-03-03 22:02:55 -08:00 committed by Anatoli Papirovski
parent f05eaa4a53
commit fe8d4a7ea7
No known key found for this signature in database
GPG Key ID: 614E2E1ABEB4B2C0
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/guides/contributing/pull-requests.md
View File

@ -401,10 +401,10 @@ seem unfamiliar, refer to this
All Pull Requests require "sign off" in order to land. Whenever a contributor All Pull Requests require "sign off" in order to land. Whenever a contributor
reviews a Pull Request they may find specific details that they would like to reviews a Pull Request they may find specific details that they would like to
see changed or fixed. These may be as simple as fixing a typo, or may involve see changed or fixed. These may be as simple as fixing a typo, or may involve
substantive changes to the code you have written. In general, such requests substantive changes to the code you have written. While such requests are
are intended to be helpful, but at times may come across as abrupt or unhelpful, intended to be helpful, they may come across as abrupt or unhelpful, especially
especially requests to change things that do not include concrete suggestions requests to change things that do not include concrete suggestions on *how* to
on *how* to change them. change them.
Try not to be discouraged. If you feel that a particular review is unfair, Try not to be discouraged. If you feel that a particular review is unfair,
say so, or contact one of the other contributors in the project and seek their say so, or contact one of the other contributors in the project and seek their
@ -610,8 +610,8 @@ however, will stay intact on the Pull Request page.
For the size of "one logical change", For the size of "one logical change",
[0b5191f](https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8) [0b5191f](https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8)
can be a good example. It touches the implementation, the documentation, can be a good example. It touches the implementation, the documentation,
and the tests, but is still one logical change. In general, the tests should and the tests, but is still one logical change. All tests should always pass
always pass when each individual commit lands on the master branch. when each individual commit lands on the master branch.
### Getting Approvals for Your Pull Request ### Getting Approvals for Your Pull Request