1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-dgram-setBroadcast.js

Browse Source 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.

PR-URL: https://github.com/nodejs/node/pull/11252
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
cjihrig 2017-02-08 22:15:19 -05:00 committed by James M Snell
parent 5cd9d76b02
commit fe2b5f0dd2
1 changed files with 17 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
test/parallel/test-dgram-setBroadcast.js
View File

@ -4,36 +4,22 @@ const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const setup = () => {
return dgram.createSocket({type: 'udp4', reuseAddr: true});
};
{
// Should throw EBADF if the socket is never bound.
const socket = dgram.createSocket('udp4');
const teardown = (socket) => {
if (socket.close)
socket.close();
};
const runTest = (testCode, expectError) => {
const socket = setup();
const assertion = expectError ? assert.throws : assert.doesNotThrow;
const wrapped = () => { testCode(socket); };
assertion(wrapped, expectError);
teardown(socket);
};
// Should throw EBADF if socket is never bound.
runTest((socket) => { socket.setBroadcast(true); }, /EBADF/);
// Should not throw if broadcast set to false after binding.
runTest((socket) => {
socket.bind(0, common.localhostIPv4, () => {
socket.setBroadcast(false);
});
});
// Should not throw if broadcast set to true after binding.
runTest((socket) => {
socket.bind(0, common.localhostIPv4, () => {
assert.throws(() => {
socket.setBroadcast(true);
});
});
}, /^Error: setBroadcast EBADF$/);
}
{
// Can call setBroadcast() after binding the socket.
const socket = dgram.createSocket('udp4');
socket.bind(0, common.mustCall(() => {
socket.setBroadcast(true);
socket.setBroadcast(false);
socket.close();
}));
}