From fdd5d4ad4a228af6e5a7dc74ddf0e03dc5637254 Mon Sep 17 00:00:00 2001
From: Shobhit Chittora <schittora@paypal.com>
Date: Sat, 14 Sep 2019 05:39:46 +0530
Subject: [PATCH] bootstrap: add exception handling for profiler bootstrap

Add exception handling for the case when profile is
not bootstrapped when coverage is enabled.

Fixes: https://github.com/nodejs/node/issues/29542

PR-URL: https://github.com/nodejs/node/pull/29552
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
---
 lib/internal/bootstrap/pre_execution.js       | 12 ++++++++--
 test/common/index.js                          |  7 ++++++
 .../test-coverage-with-inspector-disabled.js  | 24 +++++++++++++++++++
 3 files changed, 41 insertions(+), 2 deletions(-)
 create mode 100644 test/parallel/test-coverage-with-inspector-disabled.js

diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
index d18d7099280..6e7d946458d 100644
--- a/lib/internal/bootstrap/pre_execution.js
+++ b/lib/internal/bootstrap/pre_execution.js
@@ -120,8 +120,16 @@ function setupCoverageHooks(dir) {
   const { resolve } = require('path');
   const coverageDirectory = resolve(cwd, dir);
   const { sourceMapCacheToObject } = require('internal/source_map');
-  internalBinding('profiler').setCoverageDirectory(coverageDirectory);
-  internalBinding('profiler').setSourceMapCacheGetter(sourceMapCacheToObject);
+
+  if (process.features.inspector) {
+    internalBinding('profiler').setCoverageDirectory(coverageDirectory);
+    internalBinding('profiler').setSourceMapCacheGetter(sourceMapCacheToObject);
+  } else {
+    process.emitWarning('The inspector is disabled, ' +
+                        'coverage could not be collected',
+                        'Warning');
+    return '';
+  }
   return coverageDirectory;
 }
 
diff --git a/test/common/index.js b/test/common/index.js
index 98a26872223..00ebd283a0c 100644
--- a/test/common/index.js
+++ b/test/common/index.js
@@ -651,6 +651,12 @@ function skipIfInspectorDisabled() {
   }
 }
 
+function skipIfInspectorEnabled() {
+  if (process.features.inspector) {
+    skip('V8 inspector is enabled');
+  }
+}
+
 function skipIfReportDisabled() {
   if (!process.config.variables.node_report) {
     skip('Diagnostic reporting is disabled');
@@ -783,6 +789,7 @@ module.exports = {
   skipIf32Bits,
   skipIfEslintMissing,
   skipIfInspectorDisabled,
+  skipIfInspectorEnabled,
   skipIfReportDisabled,
   skipIfWorker,
 
diff --git a/test/parallel/test-coverage-with-inspector-disabled.js b/test/parallel/test-coverage-with-inspector-disabled.js
new file mode 100644
index 00000000000..0b0c2aea43f
--- /dev/null
+++ b/test/parallel/test-coverage-with-inspector-disabled.js
@@ -0,0 +1,24 @@
+'use strict';
+
+const common = require('../common');
+common.skipIfInspectorEnabled();
+
+const fixtures = require('../common/fixtures');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const env = { ...process.env, NODE_V8_COVERAGE: '/foo/bar' };
+const childPath = fixtures.path('v8-coverage/subprocess');
+const { status, stderr } = spawnSync(
+  process.execPath,
+  [childPath],
+  { env }
+);
+
+const warningMessage = 'The inspector is disabled, ' +
+                        'coverage could not be collected';
+
+assert.strictEqual(status, 0);
+assert.strictEqual(
+  stderr.toString().includes(`Warning: ${warningMessage}`),
+  true
+);