1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-fs-watchfile

Browse Source 
* use `common.mustNotCall()` to confirm callback is not called
* reorder modules to conform with test-writing guide
* match full error message in `assert.throws()`

PR-URL: https://github.com/nodejs/node/pull/13721
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-06-16 09:58:25 -07:00
parent 24ecc331e2
commit fd9a30f10e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-fs-watchfile.js
View File

@ -1,21 +1,21 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const path = require('path');
const assert = require('assert');
// Basic usage tests.
assert.throws(function() {
fs.watchFile('./some-file');
}, /"watchFile\(\)" requires a listener function/);
}, /^Error: "watchFile\(\)" requires a listener function$/);
assert.throws(function() {
fs.watchFile('./another-file', {}, 'bad listener');
}, /"watchFile\(\)" requires a listener function/);
}, /^Error: "watchFile\(\)" requires a listener function$/);
assert.throws(function() {
fs.watchFile(new Object(), common.noop);
fs.watchFile(new Object(), common.mustNotCall());
}, common.expectsError({code: 'ERR_INVALID_ARG_TYPE', type: TypeError}));
const enoentFile = path.join(common.tmpDir, 'non-existent-file');