1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: do not accept NaN in setMaxListeners

Browse Source
This commit is contained in:
Fedor Indutny 2013-11-19 10:58:23 +04:00
parent 5885f464f0
commit fce0eb416b
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/events.js
View File

@ -45,7 +45,7 @@ exports.EventEmitter = EventEmitter;
// that to be increased. Set to zero for unlimited. // that to be increased. Set to zero for unlimited.
var defaultMaxListeners = 10; var defaultMaxListeners = 10;
EventEmitter.prototype.setMaxListeners = function(n) { EventEmitter.prototype.setMaxListeners = function(n) {
if (typeof n !== 'number' || n < 0) if (typeof n !== 'number' || n < 0 || isNaN(n))
throw TypeError('n must be a positive number'); throw TypeError('n must be a positive number');
this._maxListeners = n; this._maxListeners = n;
}; };

12
test/simple/test-event-emitter-max-listeners.js
View File

@ -38,4 +38,16 @@ e.on('maxListeners', function() {
// Should not corrupt the 'maxListeners' queue. // Should not corrupt the 'maxListeners' queue.
e.setMaxListeners(42); e.setMaxListeners(42);
assert.throws(function() {
e.setMaxListeners(NaN);
});
assert.throws(function() {
e.setMaxListeners(-1);
});
assert.throws(function() {
e.setMaxListeners("and even this");
});
e.emit('maxListeners'); e.emit('maxListeners');