1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test-npm-install

Browse Source 
Make npm install a dependency that is defined as a relative path, so it
avoids any network interaction.

PR-URL: https://github.com/nodejs/node/pull/5613
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
This commit is contained in:
Santiago Gimeno 2016-03-09 00:59:59 +01:00 committed by James M Snell
parent 25eedf02a8
commit fbe0b444ef
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-npm-install.js
View File

@ -22,7 +22,11 @@ const args = [
'install' 'install'
]; ];
const pkgContent = '{}'; const pkgContent = JSON.stringify({
dependencies: {
'package-name': common.fixturesDir + '/packages/main'
}
});
const pkgPath = path.join(common.tmpDir, 'package.json'); const pkgPath = path.join(common.tmpDir, 'package.json');
@ -35,6 +39,9 @@ const proc = spawn(process.execPath, args, {
function handleExit(code, signalCode) { function handleExit(code, signalCode) {
assert.equal(code, 0, 'npm install should run without an error'); assert.equal(code, 0, 'npm install should run without an error');
assert.ok(signalCode === null, 'signalCode should be null'); assert.ok(signalCode === null, 'signalCode should be null');
assert.doesNotThrow(function() {
fs.accessSync(common.tmpDir + '/node_modules/package-name');
});
} }
proc.on('exit', common.mustCall(handleExit)); proc.on('exit', common.mustCall(handleExit));