1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: remove "note that" from async_hooks.md

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Rich Trott 2019-06-20 14:09:34 -06:00
parent 1b2f6d2d02
commit fafd98404d
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/api/async_hooks.md
View File

@ -111,7 +111,7 @@ const asyncHook = async_hooks.createHook({
}); });
``` ```
Note that the callbacks will be inherited via the prototype chain: The callbacks will be inherited via the prototype chain:
```js ```js
class MyAsyncCallbacks { class MyAsyncCallbacks {
@ -439,7 +439,7 @@ added: v8.6.0
Called when the `resolve` function passed to the `Promise` constructor is Called when the `resolve` function passed to the `Promise` constructor is
invoked (either directly or through other means of resolving a promise). invoked (either directly or through other means of resolving a promise).
Note that `resolve()` does not do any observable synchronous work. `resolve()` does not do any observable synchronous work.
The `Promise` is not necessarily fulfilled or rejected at this point if the The `Promise` is not necessarily fulfilled or rejected at this point if the
`Promise` was resolved by assuming the state of another `Promise`. `Promise` was resolved by assuming the state of another `Promise`.
@ -497,7 +497,7 @@ const server = net.createServer((conn) => {
}); });
``` ```
Note that promise contexts may not get precise `executionAsyncIds` by default. Promise contexts may not get precise `executionAsyncIds` by default.
See the section on [promise execution tracking][]. See the section on [promise execution tracking][].
#### async_hooks.triggerAsyncId() #### async_hooks.triggerAsyncId()
@ -520,7 +520,7 @@ const server = net.createServer((conn) => {
}); });
``` ```
Note that promise contexts may not get valid `triggerAsyncId`s by default. See Promise contexts may not get valid `triggerAsyncId`s by default. See
the section on [promise execution tracking][]. the section on [promise execution tracking][].
## Promise execution tracking ## Promise execution tracking
@ -540,7 +540,7 @@ Promise.resolve(1729).then(() => {
``` ```
Observe that the `then()` callback claims to have executed in the context of the Observe that the `then()` callback claims to have executed in the context of the
outer scope even though there was an asynchronous hop involved. Also note that outer scope even though there was an asynchronous hop involved. Also,
the `triggerAsyncId` value is `0`, which means that we are missing context about the `triggerAsyncId` value is `0`, which means that we are missing context about
the resource that caused (triggered) the `then()` callback to be executed. the resource that caused (triggered) the `then()` callback to be executed.