1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: change order of assert.strictEquals arguments

Browse Source 
Fix assert.strictEquals argument order.

Arguments were actual first, expected second, contrary to
the documentation. Now, actual value is first and expected
value is second.

PR-URL: https://github.com/nodejs/node/pull/23600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Chuck Theobald 2018-10-12 11:06:31 -07:00 committed by Ruben Bridgewater
parent f781b2cbea
commit f8b1e0e4b9
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/parallel/test-tcp-wrap-listen.js
View File

@ -10,7 +10,7 @@ const { WriteWrap } = internalBinding('stream_wrap');
const server = new TCP(TCPConstants.SOCKET);
const r = server.bind('0.0.0.0', 0);
assert.strictEqual(0, r);
assert.strictEqual(r, 0);
let port = {};
server.getsockname(port);
port = port.port;
@ -18,7 +18,7 @@ port = port.port;
server.listen(128);
server.onconnection = (err, client) => {
assert.strictEqual(0, client.writeQueueSize);
assert.strictEqual(client.writeQueueSize, 0);
console.log('got connection');
const maybeCloseClient = () => {
@ -34,7 +34,7 @@ server.onconnection = (err, client) => {
if (buffer) {
assert.ok(buffer.length > 0);
assert.strictEqual(0, client.writeQueueSize);
assert.strictEqual(client.writeQueueSize, 0);
const req = new WriteWrap();
req.async = false;
@ -44,7 +44,7 @@ server.onconnection = (err, client) => {
console.log(`client.writeQueueSize: ${client.writeQueueSize}`);
// 11 bytes should flush
assert.strictEqual(0, client.writeQueueSize);
assert.strictEqual(client.writeQueueSize, 0);
if (req.async)
req.oncomplete = common.mustCall(done);
@ -52,15 +52,15 @@ server.onconnection = (err, client) => {
process.nextTick(done.bind(null, 0, client, req));
function done(status, client_, req_) {
assert.strictEqual(req, client.pendingWrites.shift());
assert.strictEqual(client.pendingWrites.shift(), req);
// Check parameters.
assert.strictEqual(0, status);
assert.strictEqual(client, client_);
assert.strictEqual(req, req_);
assert.strictEqual(status, 0);
assert.strictEqual(client_, client);
assert.strictEqual(req_, req);
console.log(`client.writeQueueSize: ${client.writeQueueSize}`);
assert.strictEqual(0, client.writeQueueSize);
assert.strictEqual(client.writeQueueSize, 0);
maybeCloseClient();
}
@ -82,7 +82,7 @@ c.on('connect', common.mustCall(() => { c.end('hello world'); }));
c.setEncoding('utf8');
c.on('data', common.mustCall((d) => {
assert.strictEqual('hello world', d);
assert.strictEqual(d, 'hello world');
}));
c.on('close', () => {