1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test-http-chunked-304

Browse Source 
* change the nested functions call to run tests in parallel
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10462
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Adrian Estrada 2017-01-07 10:56:53 -05:00 committed by Luigi Pinca
parent 58c38c2d2e
commit f895715755
1 changed files with 24 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
test/parallel/test-http-chunked-304.js
View File

@ -12,32 +12,35 @@ const net = require('net');
// Likewise for 304 responses. Verify that no empty chunk is sent when // Likewise for 304 responses. Verify that no empty chunk is sent when
// the user explicitly sets a Transfer-Encoding header. // the user explicitly sets a Transfer-Encoding header.
test(204, function() { test(204);
test(304); test(304);
});
function test(statusCode, next) { function test(statusCode) {
var server = http.createServer(function(req, res) { const server = http.createServer(common.mustCall((req, res) => {
res.writeHead(statusCode, { 'Transfer-Encoding': 'chunked' }); res.writeHead(statusCode, { 'Transfer-Encoding': 'chunked' });
res.end(); res.end();
server.close(); server.close();
}); }));
server.listen(0, function() { server.listen(0, common.mustCall(() => {
var conn = net.createConnection(this.address().port, function() { const conn = net.createConnection(
conn.write('GET / HTTP/1.1\r\n\r\n'); server.address().port,
common.mustCall(() => {
conn.write('GET / HTTP/1.1\r\n\r\n');
var resp = ''; let resp = '';
conn.setEncoding('utf8'); conn.setEncoding('utf8');
conn.on('data', function(data) { conn.on('data', common.mustCall((data) => {
resp += data; resp += data;
}); }));
conn.on('end', common.mustCall(function() { conn.on('end', common.mustCall(() => {
assert.equal(/^Connection: close\r\n$/m.test(resp), true); // Connection: close should be in the response
assert.equal(/^0\r\n$/m.test(resp), false); assert.strictEqual(/^Connection: close\r\n$/m.test(resp), true);
if (next) process.nextTick(next); // Make sure this doesn't end with 0\r\n\r\n
})); assert.strictEqual(/^0\r\n$/m.test(resp), false);
}); }));
}); })
);
}));
} }