1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: refactor benchmark/assert/throws.js

Browse Source 
This is a minor refactor of benchmark/assert/throws.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: https://github.com/nodejs/node/pull/21030
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Rich Trott 2018-05-30 04:03:52 +00:00
parent b8f8ca5702
commit f86e5fc437
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
benchmark/assert/throws.js
View File

@ -1,7 +1,7 @@
'use strict'; 'use strict';
const common = require('../common.js'); const common = require('../common.js');
const assert = require('assert'); const { throws, doesNotThrow } = require('assert');
const bench = common.createBenchmark(main, { const bench = common.createBenchmark(main, {
n: [1e6], n: [1e6],
@ -14,8 +14,8 @@ const bench = common.createBenchmark(main, {
}); });
function main({ n, method }) { function main({ n, method }) {
const throws = () => { throw new TypeError('foobar'); }; const throwError = () => { throw new TypeError('foobar'); };
const doesNotThrow = () => { return 'foobar'; }; const doNotThrowError = () => { return 'foobar'; };
const regExp = /foobar/; const regExp = /foobar/;
const message = 'failure'; const message = 'failure';
var i; var i;
@ -26,30 +26,28 @@ function main({ n, method }) {
case 'doesNotThrow': case 'doesNotThrow':
bench.start(); bench.start();
for (i = 0; i < n; ++i) { for (i = 0; i < n; ++i) {
// eslint-disable-next-line no-restricted-syntax doesNotThrow(doNotThrowError);
assert.doesNotThrow(doesNotThrow);
} }
bench.end(n); bench.end(n);
break; break;
case 'throws': case 'throws':
bench.start(); bench.start();
for (i = 0; i < n; ++i) { for (i = 0; i < n; ++i) {
// eslint-disable-next-line no-restricted-syntax throws(throwError);
assert.throws(throws);
} }
bench.end(n); bench.end(n);
break; break;
case 'throws_TypeError': case 'throws_TypeError':
bench.start(); bench.start();
for (i = 0; i < n; ++i) { for (i = 0; i < n; ++i) {
assert.throws(throws, TypeError, message); throws(throwError, TypeError, message);
} }
bench.end(n); bench.end(n);
break; break;
case 'throws_RegExp': case 'throws_RegExp':
bench.start(); bench.start();
for (i = 0; i < n; ++i) { for (i = 0; i < n; ++i) {
assert.throws(throws, regExp, message); throws(throwError, regExp, message);
} }
bench.end(n); bench.end(n);
break; break;