1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use assert.strictEqual and fix setTimeout

Browse Source 
Changes assert.equal to assert.strictEqual in
two places and adds a second argument of 0
to setTimeout

PR-URL: https://github.com/nodejs/node/pull/9957
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Matt Phillips 2016-12-01 10:38:53 -06:00 committed by James M Snell
parent 244dd5b589
commit f7a35df171
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-domain-timers.js
View File

@ -8,21 +8,22 @@ var timeout;
var timeoutd = domain.create(); var timeoutd = domain.create();
timeoutd.on('error', common.mustCall(function(e) { timeoutd.on('error', common.mustCall(function(e) {
assert.equal(e.message, 'Timeout UNREFd', 'Domain should catch timer error'); assert.strictEqual(e.message, 'Timeout UNREFd',
'Domain should catch timer error');
clearTimeout(timeout); clearTimeout(timeout);
})); }));
timeoutd.run(function() { timeoutd.run(function() {
setTimeout(function() { setTimeout(function() {
throw new Error('Timeout UNREFd'); throw new Error('Timeout UNREFd');
}).unref(); }, 0).unref();
}); });
var immediated = domain.create(); var immediated = domain.create();
immediated.on('error', common.mustCall(function(e) { immediated.on('error', common.mustCall(function(e) {
assert.equal(e.message, 'Immediate Error', assert.strictEqual(e.message, 'Immediate Error',
'Domain should catch immediate error'); 'Domain should catch immediate error');
})); }));
immediated.run(function() { immediated.run(function() {