1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: using const and strictEqual

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/9926
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Fabrice Tatieze 2016-12-01 10:21:41 -06:00 committed by James M Snell
parent 6ed0e8b49c
commit f6d15b033b
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-console-instance.js
View File

@ -15,7 +15,7 @@ process.stdout.write = process.stderr.write = function() {
}; };
// make sure that the "Console" function exists // make sure that the "Console" function exists
assert.equal('function', typeof Console); assert.strictEqual('function', typeof Console);
// make sure that the Console constructor throws // make sure that the Console constructor throws
// when not given a writable stream instance // when not given a writable stream instance
@ -35,7 +35,7 @@ out.write = err.write = function(d) {};
var c = new Console(out, err); var c = new Console(out, err);
out.write = err.write = function(d) { out.write = err.write = function(d) {
assert.equal(d, 'test\n'); assert.strictEqual(d, 'test\n');
called = true; called = true;
}; };
@ -48,7 +48,7 @@ c.error('test');
assert(called); assert(called);
out.write = function(d) { out.write = function(d) {
assert.equal('{ foo: 1 }\n', d); assert.strictEqual('{ foo: 1 }\n', d);
called = true; called = true;
}; };
@ -60,10 +60,10 @@ assert(called);
called = 0; called = 0;
out.write = function(d) { out.write = function(d) {
called++; called++;
assert.equal(d, called + ' ' + (called - 1) + ' [ 1, 2, 3 ]\n'); assert.strictEqual(d, called + ' ' + (called - 1) + ' [ 1, 2, 3 ]\n');
}; };
[1, 2, 3].forEach(c.log); [1, 2, 3].forEach(c.log);
assert.equal(3, called); assert.strictEqual(3, called);
// Console() detects if it is called without `new` keyword // Console() detects if it is called without `new` keyword
assert.doesNotThrow(function() { assert.doesNotThrow(function() {

18
test/parallel/test-dgram-msgsize.js
View File

@ -1,18 +1,18 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var dgram = require('dgram'); const dgram = require('dgram');
// Send a too big datagram. The destination doesn't matter because it's // Send a too big datagram. The destination doesn't matter because it's
// not supposed to get sent out anyway. // not supposed to get sent out anyway.
var buf = Buffer.allocUnsafe(256 * 1024); const buf = Buffer.allocUnsafe(256 * 1024);
var sock = dgram.createSocket('udp4'); const sock = dgram.createSocket('udp4');
sock.send(buf, 0, buf.length, 12345, '127.0.0.1', common.mustCall(cb)); sock.send(buf, 0, buf.length, 12345, '127.0.0.1', common.mustCall(cb));
function cb(err) { function cb(err) {
assert(err instanceof Error); assert(err instanceof Error);
assert.equal(err.code, 'EMSGSIZE'); assert.strictEqual(err.code, 'EMSGSIZE');
assert.equal(err.address, '127.0.0.1'); assert.strictEqual(err.address, '127.0.0.1');
assert.equal(err.port, 12345); assert.strictEqual(err.port, 12345);
assert.equal(err.message, 'send EMSGSIZE 127.0.0.1:12345'); assert.strictEqual(err.message, 'send EMSGSIZE 127.0.0.1:12345');
sock.close(); sock.close();
} }