1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: merge url.js with url-resolve.js

Browse Source 
url.js was broken since it didn't use the common.js runner. This fixes
that issue by merging it with url-resolve.js, which also benchmarks
url.resolve.

PR-URL: https://github.com/nodejs/node/pull/5177
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
This commit is contained in:
Andreas Madsen 2016-01-29 22:15:39 +01:00 committed by Rod Vagg
parent d9079ab801
commit f6c505d0b1
2 changed files with 25 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
benchmark/url/url-resolve.js
View File

@ -3,30 +3,43 @@ var common = require('../common.js');
var url = require('url'); var url = require('url');
var v8 = require('v8'); var v8 = require('v8');
var hrefs = [
'http://example.com/',
'http://nodejs.org/docs/latest/api/url.html#url_url_format_urlobj',
'http://blog.nodejs.org/',
'https://encrypted.google.com/search?q=url&q=site:npmjs.org&hl=en',
'javascript:alert("node is awesome");',
'some.ran/dom/url.thing?oh=yes#whoo'
];
var paths = [
'../../../../../etc/passwd',
'../foo/bar?baz=boom',
'foo/bar',
'http://nodejs.org',
'./foo/bar?baz'
];
var bench = common.createBenchmark(main, { var bench = common.createBenchmark(main, {
type: ['one'], href: Object.keys(hrefs),
n: [1e5], path: Object.keys(paths),
n: [1e5]
}); });
function main(conf) { function main(conf) {
var type = conf.type;
var n = conf.n | 0; var n = conf.n | 0;
var href = hrefs[conf.href];
var inputs = { var path = paths[conf.path];
one: ['http://example.com/', '../../../../../etc/passwd'],
};
var input = inputs[type] || [];
// Force-optimize url.resolve() so that the benchmark doesn't get // Force-optimize url.resolve() so that the benchmark doesn't get
// disrupted by the optimizer kicking in halfway through. // disrupted by the optimizer kicking in halfway through.
for (var name in inputs) url.resolve(href, path);
url.resolve(inputs[name][0], inputs[name][1]);
v8.setFlagsFromString('--allow_natives_syntax'); v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(url.resolve)'); eval('%OptimizeFunctionOnNextCall(url.resolve)');
bench.start(); bench.start();
for (var i = 0; i < n; i += 1) for (var i = 0; i < n; i += 1)
url.resolve(input[0], input[1]); url.resolve(href, path);
bench.end(n); bench.end(n);
} }

41
benchmark/url/url.js
View File

@ -1,41 +0,0 @@
'use strict';
var url = require('url')
var n = 25 * 100;
var urls = [
'http://nodejs.org/docs/latest/api/url.html#url_url_format_urlobj',
'http://blog.nodejs.org/',
'https://encrypted.google.com/search?q=url&q=site:npmjs.org&hl=en',
'javascript:alert("node is awesome");',
'some.ran/dom/url.thing?oh=yes#whoo'
];
var paths = [
'../foo/bar?baz=boom',
'foo/bar',
'http://nodejs.org',
'./foo/bar?baz'
];
benchmark('parse()', url.parse);
benchmark('format()', url.format);
paths.forEach(function(p) {
benchmark('resolve("' + p + '")', function(u) {
url.resolve(u, p)
});
});
function benchmark(name, fun) {
var timestamp = process.hrtime();
for (var i = 0; i < n; ++i) {
for (var j = 0, k = urls.length; j < k; ++j) fun(urls[j]);
}
timestamp = process.hrtime(timestamp);
var seconds = timestamp[0];
var nanos = timestamp[1];
var time = seconds + nanos / 1e9;
var rate = n / time;
console.log('misc/url.js %s: %s', name, rate.toPrecision(5));
}