1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

worker: assign missing deprecation code

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/28395
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit is contained in:
James M Snell 2019-06-23 08:39:57 -05:00 committed by Anna Henningsen
parent 46a73b9409
commit f5f8a18831
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/internal/worker.js
View File

@ -232,7 +232,7 @@ class Worker extends EventEmitter {
process.emitWarning( process.emitWarning(
'Passing a callback to worker.terminate() is deprecated. ' + 'Passing a callback to worker.terminate() is deprecated. ' +
'It returns a Promise instead.', 'It returns a Promise instead.',
'DeprecationWarning', 'DEP0XXX'); 'DeprecationWarning', 'DEP0132');
this.once('exit', (exitCode) => callback(null, exitCode)); this.once('exit', (exitCode) => callback(null, exitCode));
} }

2
test/parallel/test-worker-nexttick-terminate.js
View File

@ -16,7 +16,7 @@ process.nextTick(() => {
common.expectWarning( common.expectWarning(
'DeprecationWarning', 'DeprecationWarning',
'Passing a callback to worker.terminate() is deprecated. ' + 'Passing a callback to worker.terminate() is deprecated. ' +
'It returns a Promise instead.', 'DEP0XXX'); 'It returns a Promise instead.', 'DEP0132');
w.on('message', common.mustCall(() => { w.on('message', common.mustCall(() => {
setTimeout(() => { setTimeout(() => {