1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: replace assert.equal with assert.strictEqual

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/18119
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Sho Miyamoto 2018-01-12 23:06:51 +09:00 committed by Ruben Bridgewater
parent f6ae451a96
commit f576341dc2
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/es-module/test-esm-dynamic-import.js
View File

@ -15,7 +15,7 @@ targetURL.pathname = absolutePath;
function expectErrorProperty(result, propertyKey, value) { function expectErrorProperty(result, propertyKey, value) {
Promise.resolve(result) Promise.resolve(result)
.catch(common.mustCall(error => { .catch(common.mustCall(error => {
assert.equal(error[propertyKey], value); assert.strictEqual(error[propertyKey], value);
})); }));
} }
@ -51,7 +51,7 @@ function expectOkNamespace(result) {
function expectFsNamespace(result) { function expectFsNamespace(result) {
Promise.resolve(result) Promise.resolve(result)
.then(common.mustCall(ns => { .then(common.mustCall(ns => {
assert.equal(typeof ns.default.writeFile, 'function'); assert.strictEqual(typeof ns.default.writeFile, 'function');
})); }));
} }

2
test/fixtures/es-module-loaders/loader-shared-dep.mjs vendored
View File

@ -2,6 +2,6 @@ import dep from './loader-dep.js';
import assert from 'assert'; import assert from 'assert';
export function resolve(specifier, base, defaultResolve) { export function resolve(specifier, base, defaultResolve) {
assert.equal(dep.format, 'esm'); assert.strictEqual(dep.format, 'esm');
return defaultResolve(specifier, base); return defaultResolve(specifier, base);
} }

2
test/fixtures/es-module-loaders/not-found-assert-loader.mjs vendored
View File

@ -12,7 +12,7 @@ export async function resolve (specifier, base, defaultResolve) {
await defaultResolve(specifier, base); await defaultResolve(specifier, base);
} }
catch (e) { catch (e) {
assert.equal(e.code, 'MODULE_NOT_FOUND'); assert.strictEqual(e.code, 'MODULE_NOT_FOUND');
return { return {
format: 'builtin', format: 'builtin',
url: 'fs' url: 'fs'