1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove message from strictEqual assertions

Browse Source 
If values are not equals in strictEqual assertions, an AssertionError is
thrown with a message property set equals to the value of the message
parameter. If we pass a message, this message will be printed instead of
the default message, which contains the value that is causing the error.
Hence removed the value passed as the message in strictEqual assertions
of test/parallel/test-http-response-readable.js

PR-URL: https://github.com/nodejs/node/pull/20067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
isurusiri 2018-04-16 13:00:45 +05:30 committed by Rich Trott
parent be92eab92a
commit f565bbb193
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/parallel/test-http-response-readable.js
View File

@ -31,10 +31,9 @@ const testServer = new http.Server(function(req, res) {
testServer.listen(0, function() {
http.get({ port: this.address().port }, function(res) {
assert.strictEqual(res.readable, true, 'res.readable initially true');
assert.strictEqual(res.readable, true);
res.on('end', function() {
assert.strictEqual(res.readable, false,
'res.readable set to false after end');
assert.strictEqual(res.readable, false);
testServer.close();
});
res.resume();