1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refine test-http-status-reason-invalid-chars

Browse Source 
* replace unneeded template strings with strings; there was no variable
  substitution or concatenation or anything like that

* assert.notEqual() -> assert.notStrictEqual()

PR-URL: https://github.com/nodejs/node/pull/9802
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Rich Trott 2016-11-25 20:37:19 -08:00
parent 85a6b53297
commit f540794966
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/parallel/test-http-status-reason-invalid-chars.js
View File

@ -7,7 +7,7 @@ const net = require('net');
function explicit(req, res) { function explicit(req, res) {
assert.throws(() => { assert.throws(() => {
res.writeHead(200, `OK\r\nContent-Type: text/html\r\n`); res.writeHead(200, 'OK\r\nContent-Type: text/html\r\n');
}, /Invalid character in statusMessage/); }, /Invalid character in statusMessage/);
assert.throws(() => { assert.throws(() => {
@ -20,7 +20,7 @@ function explicit(req, res) {
function implicit(req, res) { function implicit(req, res) {
assert.throws(() => { assert.throws(() => {
res.statusMessage = `OK\r\nContent-Type: text/html\r\n`; res.statusMessage = 'OK\r\nContent-Type: text/html\r\n';
res.writeHead(200); res.writeHead(200);
}, /Invalid character in statusMessage/); }, /Invalid character in statusMessage/);
res.statusMessage = 'OK'; res.statusMessage = 'OK';
@ -40,8 +40,8 @@ const server = http.createServer((req, res) => {
let left = 2; let left = 2;
const check = common.mustCall((res) => { const check = common.mustCall((res) => {
left--; left--;
assert.notEqual(res.headers['content-type'], 'text/html'); assert.notStrictEqual(res.headers['content-type'], 'text/html');
assert.notEqual(res.headers['content-type'], 'gotcha'); assert.notStrictEqual(res.headers['content-type'], 'gotcha');
if (left === 0) server.close(); if (left === 0) server.close();
}, 2); }, 2);
http.get(`${url}/explicit`, check).end(); http.get(`${url}/explicit`, check).end();