1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove test messages for assert.strictEqual

Browse Source 
Remove test messages for assert.strictEqual,
as the default messages are a better option.

PR-URL: https://github.com/nodejs/node/pull/15995
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This commit is contained in:
Ali Groening 2017-10-06 11:20:11 -07:00 committed by Joyee Cheung
parent cbbc1e4496
commit f4cab35dd8
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/parallel/test-crypto-cipher-decipher.js
View File

@ -25,7 +25,7 @@ function testCipher1(key) {
let txt = decipher.update(ciph, 'hex', 'utf8'); let txt = decipher.update(ciph, 'hex', 'utf8');
txt += decipher.final('utf8'); txt += decipher.final('utf8');
assert.strictEqual(txt, plaintext, 'encryption and decryption'); assert.strictEqual(txt, plaintext);
// streaming cipher interface // streaming cipher interface
// NB: In real life, it's not guaranteed that you can get all of it // NB: In real life, it's not guaranteed that you can get all of it
@ -39,7 +39,7 @@ function testCipher1(key) {
dStream.end(ciph); dStream.end(ciph);
txt = dStream.read().toString('utf8'); txt = dStream.read().toString('utf8');
assert.strictEqual(txt, plaintext, 'encryption and decryption with streams'); assert.strictEqual(txt, plaintext);
} }
@ -61,7 +61,7 @@ function testCipher2(key) {
let txt = decipher.update(ciph, 'base64', 'utf8'); let txt = decipher.update(ciph, 'base64', 'utf8');
txt += decipher.final('utf8'); txt += decipher.final('utf8');
assert.strictEqual(txt, plaintext, 'encryption and decryption with Base64'); assert.strictEqual(txt, plaintext);
} }
testCipher1('MySecretKey123'); testCipher1('MySecretKey123');
@ -125,17 +125,17 @@ testCipher2(Buffer.from('0123456789abcdef'));
let txt; let txt;
assert.doesNotThrow(() => txt = decipher.update(ciph, 'base64', 'ucs2')); assert.doesNotThrow(() => txt = decipher.update(ciph, 'base64', 'ucs2'));
assert.doesNotThrow(() => txt += decipher.final('ucs2')); assert.doesNotThrow(() => txt += decipher.final('ucs2'));
assert.strictEqual(txt, plaintext, 'decrypted result in ucs2'); assert.strictEqual(txt, plaintext);
decipher = crypto.createDecipher('aes192', key); decipher = crypto.createDecipher('aes192', key);
assert.doesNotThrow(() => txt = decipher.update(ciph, 'base64', 'ucs-2')); assert.doesNotThrow(() => txt = decipher.update(ciph, 'base64', 'ucs-2'));
assert.doesNotThrow(() => txt += decipher.final('ucs-2')); assert.doesNotThrow(() => txt += decipher.final('ucs-2'));
assert.strictEqual(txt, plaintext, 'decrypted result in ucs-2'); assert.strictEqual(txt, plaintext);
decipher = crypto.createDecipher('aes192', key); decipher = crypto.createDecipher('aes192', key);
assert.doesNotThrow(() => txt = decipher.update(ciph, 'base64', 'utf-16le')); assert.doesNotThrow(() => txt = decipher.update(ciph, 'base64', 'utf-16le'));
assert.doesNotThrow(() => txt += decipher.final('utf-16le')); assert.doesNotThrow(() => txt += decipher.final('utf-16le'));
assert.strictEqual(txt, plaintext, 'decrypted result in utf-16le'); assert.strictEqual(txt, plaintext);
} }
// setAutoPadding/setAuthTag/setAAD should return `this` // setAutoPadding/setAuthTag/setAAD should return `this`