1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve path tests

Browse Source 
Replaced deepStrictEqual with strictEqual when asserting that the
path is equal to the win32 or posix equivalent, since it is a more
strict check than deepStrictCheck. Also removed third argument
in the check so that if there is an assertion error the properties
that are different will be displayed.

PR-URL: https://github.com/nodejs/node/pull/20967
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Shivang 2018-05-25 14:12:36 -04:00 committed by Anatoli Papirovski
parent cf72301545
commit f49bd39cde
No known key found for this signature in database
GPG Key ID: 614E2E1ABEB4B2C0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-path.js
View File

@ -68,6 +68,6 @@ assert.strictEqual(path.win32.delimiter, ';');
assert.strictEqual(path.posix.delimiter, ':');
if (common.isWindows)
assert.deepStrictEqual(path, path.win32, 'should be win32 path module');
assert.strictEqual(path, path.win32);
else
assert.deepStrictEqual(path, path.posix, 'should be posix path module');
assert.strictEqual(path, path.posix);