1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cluster: deprecate worker.suicide

Browse Source 
Deprecate worker.suicide in favor of worker.exitedAfterDisconnect.

PR-URL: https://github.com/nodejs/node/pull/3747
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This commit is contained in:
Evan Lucas 2016-06-02 06:45:33 -05:00
parent abd0d68bea
commit f44b18f010
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/cluster.js
View File

@ -6,6 +6,7 @@ const dgram = require('dgram');
const fork = require('child_process').fork; const fork = require('child_process').fork;
const net = require('net'); const net = require('net');
const util = require('util'); const util = require('util');
const internalUtil = require('internal/util');
const SCHED_NONE = 1; const SCHED_NONE = 1;
const SCHED_RR = 2; const SCHED_RR = 2;
@ -30,14 +31,14 @@ function Worker(options) {
this.exitedAfterDisconnect = undefined; this.exitedAfterDisconnect = undefined;
Object.defineProperty(this, 'suicide', { Object.defineProperty(this, 'suicide', {
get: function() { get: internalUtil.deprecate(() => {
// TODO: Print deprecation message.
return this.exitedAfterDisconnect; return this.exitedAfterDisconnect;
}, }, 'worker.suicide is deprecated. ' +
set: function(val) { 'Please use worker.exitedAfterDisconnect.'),
// TODO: Print deprecation message. set: internalUtil.deprecate((val) => {
this.exitedAfterDisconnect = val; this.exitedAfterDisconnect = val;
}, }, 'worker.suicide is deprecated. ' +
'Please use worker.exitedAfterDisconnect.'),
enumerable: true enumerable: true
}); });