1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-stream-transform-object

Browse Source 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: https://github.com/nodejs/node/pull/10588
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Rich Trott 2017-01-02 22:27:40 -08:00
parent 132e44b402
commit f43ea2a6ae
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
test/parallel/test-stream-transform-objectmode-falsey-value.js
View File

@ -1,33 +1,30 @@
'use strict'; 'use strict';
require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const stream = require('stream'); const stream = require('stream');
var PassThrough = stream.PassThrough; const PassThrough = stream.PassThrough;
var src = new PassThrough({ objectMode: true }); const src = new PassThrough({ objectMode: true });
var tx = new PassThrough({ objectMode: true }); const tx = new PassThrough({ objectMode: true });
var dest = new PassThrough({ objectMode: true }); const dest = new PassThrough({ objectMode: true });
var expect = [ -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; const expect = [ -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ];
var results = []; const results = [];
process.on('exit', function() {
assert.deepStrictEqual(results, expect);
console.log('ok');
});
dest.on('data', function(x) { dest.on('data', common.mustCall(function(x) {
results.push(x); results.push(x);
}); }, expect.length));
src.pipe(tx).pipe(dest); src.pipe(tx).pipe(dest);
var i = -1; let i = -1;
var int = setInterval(function() { const int = setInterval(common.mustCall(function() {
if (i > 10) { if (results.length === expect.length) {
src.end(); src.end();
clearInterval(int); clearInterval(int);
assert.deepStrictEqual(results, expect);
} else { } else {
src.write(i++); src.write(i++);
} }
}); }, expect.length + 1), 1);