1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: modernize child_process example code

Browse Source 
1. equal => strictEqual.
2. let => const for the variable that is not reassigned.
3. fix spaces.
4. stringify erroneous raw buffer outputs.
5. fix a typo.

PR-URL: https://github.com/nodejs/node/pull/10102
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Vse Mozhet Byt 2016-12-03 07:36:19 +02:00 committed by Sam Roberts
parent 10929f6cb6
commit f418a22767
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
doc/api/child_process.md
View File

@ -91,11 +91,11 @@ const spawn = require('child_process').spawn;
const bat = spawn('cmd.exe', ['/c', 'my.bat']); const bat = spawn('cmd.exe', ['/c', 'my.bat']);
bat.stdout.on('data', (data) => { bat.stdout.on('data', (data) => {
console.log(data); console.log(data.toString());
}); });
bat.stderr.on('data', (data) => { bat.stderr.on('data', (data) => {
console.log(data); console.log(data.toString());
}); });
bat.on('exit', (code) => { bat.on('exit', (code) => {
@ -113,7 +113,7 @@ exec('my.bat', (err, stdout, stderr) => {
}); });
// Script with spaces in the filename: // Script with spaces in the filename:
const bat = spawn('"my script.cmd"', ['a', 'b'], { shell:true }); const bat = spawn('"my script.cmd"', ['a', 'b'], { shell: true });
// or: // or:
exec('"my script.cmd" a b', (err, stdout, stderr) => { exec('"my script.cmd" a b', (err, stdout, stderr) => {
// ... // ...
@ -383,7 +383,7 @@ ps.on('close', (code) => {
}); });
grep.stdout.on('data', (data) => { grep.stdout.on('data', (data) => {
console.log(`${data}`); console.log(data.toString());
}); });
grep.stderr.on('data', (data) => { grep.stderr.on('data', (data) => {
@ -467,8 +467,8 @@ const out = fs.openSync('./out.log', 'a');
const err = fs.openSync('./out.log', 'a'); const err = fs.openSync('./out.log', 'a');
const child = spawn('prg', [], { const child = spawn('prg', [], {
detached: true, detached: true,
stdio: [ 'ignore', out, err ] stdio: [ 'ignore', out, err ]
}); });
child.unref(); child.unref();
@ -860,7 +860,7 @@ as in this example:
'use strict'; 'use strict';
const spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
let child = spawn('sh', ['-c', const child = spawn('sh', ['-c',
`node -e "setInterval(() => { `node -e "setInterval(() => {
console.log(process.pid, 'is alive') console.log(process.pid, 'is alive')
}, 500);"` }, 500);"`
@ -1107,21 +1107,21 @@ const fs = require('fs');
const child_process = require('child_process'); const child_process = require('child_process');
const child = child_process.spawn('ls', { const child = child_process.spawn('ls', {
stdio: [ stdio: [
0, // Use parents stdin for child 0, // Use parent's stdin for child
'pipe', // Pipe child's stdout to parent 'pipe', // Pipe child's stdout to parent
fs.openSync('err.out', 'w') // Direct child's stderr to a file fs.openSync('err.out', 'w') // Direct child's stderr to a file
] ]
}); });
assert.equal(child.stdio[0], null); assert.strictEqual(child.stdio[0], null);
assert.equal(child.stdio[0], child.stdin); assert.strictEqual(child.stdio[0], child.stdin);
assert(child.stdout); assert(child.stdout);
assert.equal(child.stdio[1], child.stdout); assert.strictEqual(child.stdio[1], child.stdout);
assert.equal(child.stdio[2], null); assert.strictEqual(child.stdio[2], null);
assert.equal(child.stdio[2], child.stderr); assert.strictEqual(child.stdio[2], child.stderr);
``` ```
### child.stdout ### child.stdout