From f3f3f8890c2e2364ca88f043e1ab675d72c370e6 Mon Sep 17 00:00:00 2001 From: Anatoli Papirovski Date: Fri, 5 Jan 2018 11:42:39 -0500 Subject: [PATCH] lib: enable dot-notation eslint rule PR-URL: https://github.com/nodejs/node/pull/18007 Reviewed-By: Anna Henningsen Reviewed-By: Ruben Bridgewater Reviewed-By: Eugene Ostroukhov Reviewed-By: James M Snell Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Roman Reiss Reviewed-By: Jon Moss --- lib/.eslintrc.yaml | 2 ++ lib/inspector.js | 2 +- lib/module.js | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml index aaebadca125..437aa575645 100644 --- a/lib/.eslintrc.yaml +++ b/lib/.eslintrc.yaml @@ -1,4 +1,6 @@ rules: + dot-notation: error + # Custom rules in tools/eslint-rules require-buffer: error buffer-constructor: error diff --git a/lib/inspector.js b/lib/inspector.js index 091e0e5fc9b..5206024f7b9 100644 --- a/lib/inspector.js +++ b/lib/inspector.js @@ -68,7 +68,7 @@ class Session extends EventEmitter { const id = this[nextIdSymbol]++; const message = { id, method }; if (params) { - message['params'] = params; + message.params = params; } if (callback) { this[messageCallbacksSymbol].set(id, callback); diff --git a/lib/module.js b/lib/module.js index 4c4ceaf847f..4e41422b585 100644 --- a/lib/module.js +++ b/lib/module.js @@ -729,7 +729,7 @@ Module._initPaths = function() { paths.unshift(path.resolve(homeDir, '.node_modules')); } - var nodePath = process.env['NODE_PATH']; + var nodePath = process.env.NODE_PATH; if (nodePath) { paths = nodePath.split(path.delimiter).filter(function(path) { return !!path;