1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: reduce CI options in COLLABORATOR_GUIDE.md

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/19458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
This commit is contained in:
Rich Trott 2018-03-19 12:02:18 -07:00
parent be470943fb
commit f3e078fdce
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
COLLABORATOR_GUIDE.md
View File

@ -192,9 +192,9 @@ All bugfixes require a test case which demonstrates the defect. The
test should *fail* before the change, and *pass* after the change. test should *fail* before the change, and *pass* after the change.
All pull requests that modify executable code should also include a test case All pull requests that modify executable code should also include a test case
and be subjected to continuous integration tests on the and must be subjected to continuous integration tests on the
[project CI server](https://ci.nodejs.org/). The pull request should have a CI [project CI server](https://ci.nodejs.org/). The pull request should have a CI
status indicator if possible. status indicator.
#### Useful CI Jobs #### Useful CI Jobs
@ -203,13 +203,9 @@ is the standard CI run we do to check Pull Requests. It triggers
`node-test-commit`, which runs the `build-ci` and `test-ci` targets on all `node-test-commit`, which runs the `build-ci` and `test-ci` targets on all
supported platforms. supported platforms.
* [`node-test-linter`](https://ci.nodejs.org/job/node-test-linter/)
only runs the linter targets, which is useful for changes that only affect
comments or documentation.
* [`node-test-pull-request-lite`](https://ci.nodejs.org/job/node-test-pull-request-lite/) * [`node-test-pull-request-lite`](https://ci.nodejs.org/job/node-test-pull-request-lite/)
only runs the linter job, as well as the tests on LinuxONE. Should only be used only runs the linter job, as well as the tests on LinuxONE, which is very fast.
for trivial changes that do not require being tested on all platforms. This is useful for changes that only affect comments or documentation.
* [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/) * [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/)
uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run