1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactored to remove unnecessary variables

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17553
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Mithun Sasidharan 2017-12-08 22:44:28 +05:30 committed by Jon Moss
parent 8d23afc807
commit f3aaaa52b7
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/parallel/test-net-connect-options-fd.js
View File

@ -83,14 +83,13 @@ const forAllClients = (cb) => common.mustCall(cb, CLIENT_VARIANTS);
path: serverPath path: serverPath
}); });
const getConnectCb = (index) => common.mustCall(function clientOnConnect() { const getConnectCb = (index) => common.mustCall(function clientOnConnect() {
const client = this;
// Test if it's wrapping an existing fd // Test if it's wrapping an existing fd
assert(handleMap.has(index)); assert(handleMap.has(index));
const oldHandle = handleMap.get(index); const oldHandle = handleMap.get(index);
assert.strictEqual(oldHandle.fd, this._handle.fd); assert.strictEqual(oldHandle.fd, this._handle.fd);
client.write(String(oldHandle.fd)); this.write(String(oldHandle.fd));
console.error(`[Pipe]Sending data through fd ${oldHandle.fd}`); console.error(`[Pipe]Sending data through fd ${oldHandle.fd}`);
client.on('error', function(err) { this.on('error', function(err) {
console.error(err); console.error(err);
assert.fail(null, null, `[Pipe Client]${err}`); assert.fail(null, null, `[Pipe Client]${err}`);
}); });

5
test/parallel/test-net-connect-options-path.js
View File

@ -20,9 +20,8 @@ const CLIENT_VARIANTS = 12;
}, CLIENT_VARIANTS)) }, CLIENT_VARIANTS))
.listen(serverPath, common.mustCall(function() { .listen(serverPath, common.mustCall(function() {
const getConnectCb = () => common.mustCall(function() { const getConnectCb = () => common.mustCall(function() {
const client = this; this.end();
client.end(); this.on('close', common.mustCall(function() {
client.on('close', common.mustCall(function() {
counter++; counter++;
if (counter === CLIENT_VARIANTS) { if (counter === CLIENT_VARIANTS) {
server.close(); server.close();