1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

child_process: defer error to next tick

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/4670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This commit is contained in:
Tristian Flanagan 2016-01-13 10:00:19 -05:00 committed by Rich Trott
parent 5ea25d2ebe
commit f2b01cba7b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/internal/child_process.js
View File

@ -599,7 +599,7 @@ function setupChannel(target, channel) {
if (typeof callback === 'function') { if (typeof callback === 'function') {
process.nextTick(callback, ex); process.nextTick(callback, ex);
} else { } else {
this.emit('error', ex); // FIXME(bnoordhuis) Defer to next tick. process.nextTick(() => this.emit('error', ex));
} }
return false; return false;
}; };
@ -713,7 +713,7 @@ function setupChannel(target, channel) {
if (typeof callback === 'function') { if (typeof callback === 'function') {
process.nextTick(callback, ex); process.nextTick(callback, ex);
} else { } else {
this.emit('error', ex); // FIXME(bnoordhuis) Defer to next tick. process.nextTick(() => this.emit('error', ex));
} }
} }
} }