1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove fixturesDir from common module

Browse Source 
Remove common.fixturesDir. All tests now use the the common/fixtures
module instead.

PR-URL: https://github.com/nodejs/node/pull/17400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Rich Trott 2017-12-02 01:26:35 -08:00
parent f9660b7166
commit f299922068
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/common/README.md
View File

@ -127,11 +127,6 @@ Returns a new promise that will propagate `promise` resolution or rejection if
that happens within the `timeoutMs` timespan, or rejects with `error` as that happens within the `timeoutMs` timespan, or rejects with `error` as
a reason otherwise. a reason otherwise.
### fixturesDir
* [&lt;String>]
Path to the 'fixtures' directory.
### getArrayBufferViews(buf) ### getArrayBufferViews(buf)
* `buf` [&lt;Buffer>] * `buf` [&lt;Buffer>]
* return [&lt;ArrayBufferView&#91;&#93;>] * return [&lt;ArrayBufferView&#91;&#93;>]

4
test/common/index.js
View File

@ -36,8 +36,6 @@ const testRoot = process.env.NODE_TEST_DIR ?
const noop = () => {}; const noop = () => {};
exports.fixturesDir = fixturesDir;
// Using a `.` prefixed name, which is the convention for "hidden" on POSIX, // Using a `.` prefixed name, which is the convention for "hidden" on POSIX,
// gets tools to ignore it by default or by simple rules, especially eslint. // gets tools to ignore it by default or by simple rules, especially eslint.
let tmpDirName = '.tmp'; let tmpDirName = '.tmp';
@ -303,7 +301,7 @@ exports.childShouldThrowAndAbort = function() {
exports.ddCommand = function(filename, kilobytes) { exports.ddCommand = function(filename, kilobytes) {
if (exports.isWindows) { if (exports.isWindows) {
const p = path.resolve(exports.fixturesDir, 'create-file.js'); const p = path.resolve(fixturesDir, 'create-file.js');
return `"${process.argv[0]}" "${p}" "${filename}" ${kilobytes * 1024}`; return `"${process.argv[0]}" "${p}" "${filename}" ${kilobytes * 1024}`;
} else { } else {
return `dd if=/dev/zero of="${filename}" bs=1024 count=${kilobytes}`; return `dd if=/dev/zero of="${filename}" bs=1024 count=${kilobytes}`;