test: refactor test-http2-compat-serverresponse-finished.js

PR-URL: https://github.com/nodejs/node/pull/21929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Anto Aravinth 2018-07-28 10:00:32 +05:30 committed by Trivikram Kamat
parent 19aa41c6fc
commit f2518c4915

View File

@ -9,14 +9,14 @@ const net = require('net');
// Http2ServerResponse.finished // Http2ServerResponse.finished
const server = h2.createServer(); const server = h2.createServer();
server.listen(0, common.mustCall(function() { server.listen(0, common.mustCall(() => {
const port = server.address().port; const port = server.address().port;
server.once('request', common.mustCall(function(request, response) { server.once('request', common.mustCall((request, response) => {
assert.ok(response.socket instanceof net.Socket); assert.ok(response.socket instanceof net.Socket);
assert.ok(response.connection instanceof net.Socket); assert.ok(response.connection instanceof net.Socket);
assert.strictEqual(response.socket, response.connection); assert.strictEqual(response.socket, response.connection);
response.on('finish', common.mustCall(function() { response.on('finish', common.mustCall(() => {
assert.strictEqual(response.socket, undefined); assert.strictEqual(response.socket, undefined);
assert.strictEqual(response.connection, undefined); assert.strictEqual(response.connection, undefined);
process.nextTick(common.mustCall(() => { process.nextTick(common.mustCall(() => {
@ -30,7 +30,7 @@ server.listen(0, common.mustCall(function() {
})); }));
const url = `http://localhost:${port}`; const url = `http://localhost:${port}`;
const client = h2.connect(url, common.mustCall(function() { const client = h2.connect(url, common.mustCall(() => {
const headers = { const headers = {
':path': '/', ':path': '/',
':method': 'GET', ':method': 'GET',
@ -38,7 +38,7 @@ server.listen(0, common.mustCall(function() {
':authority': `localhost:${port}` ':authority': `localhost:${port}`
}; };
const request = client.request(headers); const request = client.request(headers);
request.on('end', common.mustCall(function() { request.on('end', common.mustCall(() => {
client.close(); client.close();
})); }));
request.end(); request.end();