1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

meta: clarify fast-track approval

Browse Source 
Refs: https://github.com/nodejs/node/pull/23725#issuecomment-431202936

PR-URL: https://github.com/nodejs/node/pull/23744
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
James M Snell 2018-10-18 17:45:47 -07:00
parent 1d5aba1a78
commit f14274714d
No known key found for this signature in database
GPG Key ID: 7341B15C070877AC
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
COLLABORATOR_GUIDE.md
View File

@ -187,7 +187,9 @@ Collaborators that previously approved the pull request. If someone disagrees
with the fast-tracking request, remove the label and leave a comment indicating with the fast-tracking request, remove the label and leave a comment indicating
why the pull request should not be fast-tracked. The pull request can be landed why the pull request should not be fast-tracked. The pull request can be landed
once two or more Collaborators approve both the pull request and the once two or more Collaborators approve both the pull request and the
fast-tracking request, and the necessary CI testing is done. fast-tracking request, and the necessary CI testing is done. A request to
fast-track a PR made by a different Collaborator than the pull-request author
counts as a fast-track approval.
### Testing and CI ### Testing and CI